x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 8 Apr 2009 13:43:12 +0000 (14:43 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 8 Apr 2009 13:43:12 +0000 (14:43 +0100)
Actually this is already done by rcu_lock_target_domain_by_id(). Oops.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen/arch/x86/hvm/hvm.c

index b8b15790413ca9e1bb7cf931626695ca192769c5..82b99ab761f43f41270e7eca6df05860c15316c3 100644 (file)
@@ -2439,10 +2439,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( (curr_d != d) && !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail;
@@ -2621,10 +2617,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail2;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail2;
@@ -2663,10 +2655,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail3;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail3;
@@ -2723,10 +2711,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail4;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail4;